This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Update voice collection strings#1611
Merged
Merged
Conversation
Updating legal language around voice collection permissions
bluemarvin
suggested changes
Aug 20, 2019
| <!-- This string is displayed in the title of the Voice Search samples collect dialog. That dialog is shown the first time | ||
| a user tries to use the voice search. --> | ||
| <string name="voice_samples_collect_dialog_title">Allow Firefox to Anonymously Collect Voice Samples?</string> | ||
| <string name="voice_samples_collect_dialog_title">Allow Firefox Reality to Collect Voice Samples for Research?</string> |
Contributor
There was a problem hiding this comment.
I just realized we shouldn't have Firefox or Firefox Reality in the strings file. See:
I actually saw a few other places where the app name was hardcoded in the strings.xml file.
bluemarvin
approved these changes
Aug 20, 2019
bluemarvin
left a comment
bluemarvin
left a comment
Contributor
There was a problem hiding this comment.
It was decided to land this and fix strings.xml in a follow up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating legal language around voice collection permissions